Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design: add 71953-go-dynamic-tls.md #56

Closed
wants to merge 1 commit into from
Closed

design: add 71953-go-dynamic-tls.md #56

wants to merge 1 commit into from

Conversation

amusman
Copy link
Contributor

@amusman amusman commented Jan 27, 2025 •
edited
Loading

@gopherbot
Copy link

This PR (HEAD: fd5b052) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/proposal/+/644615.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/644615.
After addressing review feedback, remember to publish your drafts!

amusman added a commit to amusman/proposal that referenced this pull request Jan 28, 2025
@amusman
design: add 54805-go-dynamic-tls.md
4e0420b 
For golang/go#54805

Change-Id: Ie6f3641dbea4a4e0993289f8db25bbe6c228724c
GitHub-Last-Rev: fd5b052
GitHub-Pull-Request: golang#56
@amusman amusman force-pushed the 54805-go-dynamic-tls branch from fd5b052 to 4e0420b Compare January 28, 2025 16:07
@gopherbot
Copy link

This PR (HEAD: 4e0420b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/proposal/+/644615.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Alexander Musman:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/644615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alexander Musman:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/644615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/644615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Alexander Musman:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/644615.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/644615.
After addressing review feedback, remember to publish your drafts!

amusman added a commit to amusman/proposal that referenced this pull request Feb 26, 2025
@amusman
design: add 71953-go-dynamic-tls.md
20de9c7 
For golang/go#71953
For golang/go#54805

Change-Id: Ie6f3641dbea4a4e0993289f8db25bbe6c228724c
GitHub-Last-Rev: fd5b052
GitHub-Pull-Request: golang#56
@amusman amusman force-pushed the 54805-go-dynamic-tls branch from 4e0420b to 20de9c7 Compare February 26, 2025 18:41
@gopherbot
Copy link

This PR (HEAD: 20de9c7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/proposal/+/644615.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/644615.
After addressing review feedback, remember to publish your drafts!

@amusman
design: add 71953-go-dynamic-tls.md
ec997ee 
For golang/go#71953
For golang/go#54805

Change-Id: Ie6f3641dbea4a4e0993289f8db25bbe6c228724c
GitHub-Last-Rev: fd5b052
GitHub-Pull-Request: golang#56
@amusman amusman force-pushed the 54805-go-dynamic-tls branch from 20de9c7 to ec997ee Compare February 27, 2025 19:52
@gopherbot
Copy link

This PR (HEAD: ec997ee) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/proposal/+/644615.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@amusman amusman changed the title design: add 54805-go-dynamic-tls.md design: add 71953-go-dynamic-tls.md Feb 27, 2025
@gopherbot
Copy link

Message from Alexander Musman:

Patch Set 5:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/644615.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Feb 27, 2025
@amusman @gopherbot
design: add 71953-go-dynamic-tls.md
2c02d6b 
For golang/go#71953

Change-Id: Ie6f3641dbea4a4e0993289f8db25bbe6c228724c
GitHub-Last-Rev: ec997ee
GitHub-Pull-Request: #56
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/644615
Commit-Queue: Ian Lance Taylor <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/644615 has been merged.

@gopherbot gopherbot closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amusman @gopherbot