Skip to content

Commit

Permalink
cmd/govulncheck: mask dirty dependency versions
Browse files Browse the repository at this point in the history
Go tip has a new change that creates a valid dirty Go version
for dependencies that were before always (devel). We mask such versions
to devel for the tests to pass. We will remove this mask after the new
change to Go versioning is the only one supported on builders.

Change-Id: I0b8bc6238db47fbf808401047dfb6d5676d2f6c4
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/630735
Reviewed-by: Ian Cottrell <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
  • Loading branch information
zpavlinovic committed Nov 22, 2024
1 parent 072d4ef commit bf472d2
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions cmd/govulncheck/testdata/common/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
"replace": "modified 01 Jan 21 00:00 UTC)"
},
{
"pattern": "Go: (go1.[\\.\\d]*|devel).*",
"pattern": "Go: (go1.[\\.\\d]*|devel(.*)).*",
"replace": "Go: go1.18"
},
{
"pattern": "\"go_version\": \"go(.*)\"",
"pattern": "\"go_version\": \"(go(.*)|devel(.*))\"",
"replace": "\"go_version\": \"go1.18\""
},
{
Expand All @@ -43,6 +43,10 @@
{
"pattern": "path\": \"stdlib\",\n *\"version\": \"(.*)\"",
"replace": "path\": \"stdlib\",\n \"version\": \"v1.18.0\""
},
{
"pattern": "\"version\": \"(.*)dirty\"",
"replace": "\"version\": \"(devel)\""
}
]
}

0 comments on commit bf472d2

Please sign in to comment.