[Navigation Material] Catch exceptions when hiding sheet #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting When our `sheetState.hide()` call got cancelled (e.g. when the activity/ModalBottomSheetLayout size changed, like when showing IME and adding ime padding), so would the whole produceState block. We now catch (and ignore) exceptions from `hide()` as there is no actionable resolution for us. Test: Manual test, instrumented test blocked by b/269613287 Fixes: google#1503, google#1499
jbw0033
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When our
sheetState.hide()call got cancelled (e.g. when the activity/ModalBottomSheetLayout size changed, like when showing IME and adding ime padding), so would the whole produceState block. We now catch (and ignore) exceptions fromhide()as there is no actionable resolution for us.Test: Manual test, instrumented test blocked by b/269613287
Fixes: #1503, #1499