[TestHarness] Deprecate testharness #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvanyo
commented
Jan 25, 2024
| @@ -110,6 +110,7 @@ dependencies { | |||
| implementation(libs.androidx.core) | |||
| testImplementation(libs.androidx.core) | |||
| implementation(libs.kotlin.coroutines.android) | |||
| implementation(libs.compose.ui.test) | |||
There was a problem hiding this comment.
Added for use in the ReplaceWith in the @Deprecated annotation.
alexvanyo
commented
Jan 25, 2024
| @@ -70,6 +70,32 @@ import kotlin.math.floor | |||
| * the [isScreenRound] will be left unchanged. | |||
| */ | |||
| @Composable | |||
| @Deprecated( | |||
| replaceWith = ReplaceWith( | |||
There was a problem hiding this comment.
This isn't a perfect ReplaceWith - the resulting code will likely be far more verbose than necessary, with the assumption that usually only one or a couple parameters were specified, but it brings in the imports and can then be edited down to the important ones.
|
This looks good, let me branch off Compose 1.6 before we merge this in though |
bentrengrove
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates testharness with the replacement of
DeviceConfigurationOverride.This PR also replaces the internal usage in some other module's tests, and provides a migration guide to the new methods.