Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to opencontainers/cgroups repository (includes update from golang 1.22 to 1.24) #3664

Merged

Conversation

dims
Copy link
Collaborator

@dims dims commented Feb 28, 2025

In support of kubernetes/kubernetes#128157

https://github.com/opencontainers/cgroups is now ready!

We still have a reference to the older repo, but we can deal with it in a follow up:

❯ rg "opencontainers/runc/libcontainer" | grep "\.go"
resctrl/utils.go:       "github.com/opencontainers/runc/libcontainer/intelrdt"
resctrl/utils_test.go:  "github.com/opencontainers/runc/libcontainer/intelrdt"
utils/sysfs/sysfs.go:// isCPUOnline is copied from github.com/opencontainers/runc/libcontainer/cgroups/fs and modified to suite cAdvisor

@dims dims force-pushed the switch-to-opencontainers-cgroups-repository branch 5 times, most recently from edb1832 to 18cb876 Compare February 28, 2025 12:04
@dims dims changed the title Switch to opencontainers/cgroups repository Switch to opencontainers/cgroups repository (includes update from golang 1.22 to 1.24) Feb 28, 2025
Signed-off-by: Davanum Srinivas <[email protected]>
@dims dims force-pushed the switch-to-opencontainers-cgroups-repository branch from 18cb876 to d448bc1 Compare February 28, 2025 21:36
@dims dims requested review from cwangVT and bobbypage March 1, 2025 01:58
@dims dims force-pushed the switch-to-opencontainers-cgroups-repository branch from 616ec6e to d448bc1 Compare March 2, 2025 00:01
@mrunalp
Copy link
Collaborator

mrunalp commented Mar 3, 2025

LGTM

@dims
Copy link
Collaborator Author

dims commented Mar 4, 2025

@mrunalp looks like in this repo, you need to use the github approval thingy ... Merging can be performed automatically with 1 approving review.

@dchen1107
Copy link
Collaborator

/approve

@dims
Copy link
Collaborator Author

dims commented Mar 4, 2025

@cwangVT you need to update the list of required checks as currently this wont merge

image

@cwangVT cwangVT merged commit 0bf663a into google:master Mar 4, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants