Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make resctrl optional/pluggable #3668

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

dims
Copy link
Collaborator

@dims dims commented Mar 4, 2025

"github.com/opencontainers/runc/libcontainer/intelrdt" is being picked up from resctrl package, this should be pluggable similar to the container plugins we have, so we folks who need it can import it explicitly using an import.

_ "github.com/google/cadvisor/resctrl/intel/install"

We have to do this here to drop the reference to opencontainers/runc entirely from kubernetes/kubernetes

Signed-off-by: Davanum Srinivas <[email protected]>
@dims dims force-pushed the make-resctrl-optional-pluggable branch from 7894315 to 552905c Compare March 4, 2025 21:40
@dims dims changed the title [WIP] Make resctrl optional/pluggable Make resctrl optional/pluggable Mar 4, 2025
@dims dims merged commit 0b675de into google:master Mar 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants