Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions workflow to tag new releases from .github/piper-cut-cl.json #4223

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

lauraharker
Copy link
Contributor

This workflow will run whenever a new commit is pushed to master.

If .github/piper-cut-cl.json is unchanged from the previous commit, this workflow does nothing.

Otherwise, the workflow finds the most recent commit prior to the new cut CL, and creates a new tag based on that commit.

Part of #4220.

For example, from my closure-compiler fork, here's:

@lauraharker lauraharker requested a review from 12wrigja February 25, 2025 01:39
@lauraharker
Copy link
Contributor Author

Alternatively we could find the version id from .github/piper-cut-cl.json & always check if that exists as a tag, anywhere -

I think the behavior should be equivalent when everything's working, but:

  • this approach is slightly faster, since the step of fetching all known tags can take 20-30 seconds
  • this approach would also skip more release tags if the CI were broken for other reasons, though - when the CI was fixed, we wouldn't go back and create a tag for the current .github/piper-cut-cl.json

@lauraharker
Copy link
Contributor Author

@ChadKillingsworth FYI

@copybara-service copybara-service bot merged commit ca16e3a into google:master Feb 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants