Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photoshop cannot open files #1

Closed
MegaByte opened this issue Oct 25, 2016 · 5 comments
Closed

Photoshop cannot open files #1

MegaByte opened this issue Oct 25, 2016 · 5 comments

Comments

@MegaByte
Copy link

Photoshop under OS X cannot open many files produced by guetzli. It returns with error "Could not complete your request because an invalid non-baseline JPEG table number >= 2 is found." I am also told that they don't work under OS X Preview for some people. I can run them through jpegtran to get them to work everywhere.

@robryk
Copy link
Contributor

robryk commented Oct 26, 2016

Can you provide an example of Guetzli output that demonstrates the Photoshop problem? Also, version of Photoshop you're using might be useful.

Do such files work for you in Preview (I'm not sure if they did work for you in Preview or if you didn't say either way)?

@MegaByte
Copy link
Author

Source: tot_defaultpngsettings
Output: tot_guetzli_84
Quality doesn't appear to matter -- I get the error with all qualities on this file (as well as others). I experienced the problem on Photoshop 2015.5 macOS 10.12.1. I did not have a problem in Finder. On the computer where Finder also didn't work, it was Photoshop 2015.5 and OS X 10.10.5.

@robryk
Copy link
Contributor

robryk commented Oct 28, 2016

I think I've found the issue. Would you mind verifing if the attached file can be opened in Photoshop?

File:
image

@MegaByte
Copy link
Author

Yes, that file works for me.

robryk added a commit that referenced this issue Oct 28, 2016
We were previously generating SOF for a "baseline" image, which means
that we shouldn't use more than 2 Huffman tables for each of AC and DC.
This was the likely cause of #1.
@robryk
Copy link
Contributor

robryk commented Oct 28, 2016

Thanks. The commit I've just pushed should fix the problem.

@robryk robryk closed this as completed Oct 28, 2016
robryk referenced this issue in robryk/guetzli Nov 23, 2016
Add a png comparison tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants