Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build fail of base/iconv.cc, FreeBSD #27

Closed
GoogleCodeExporter opened this issue Apr 22, 2015 · 8 comments
Closed

build fail of base/iconv.cc, FreeBSD #27

GoogleCodeExporter opened this issue Apr 22, 2015 · 8 comments
Labels
auto-migrated OpSys-FreeBSD Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

version: mozc-0.13.464.102
target file: base/iconv.cc
category: build fail
OS: FreeBSD 9-CURRENT / 8.1-RELEASE
CC: gcc 4.2.1 (FreeBSD default compiler)


base/iconv.cc build fails on FreeBSD because of follow line:

     if (iconv(ic, reinterpret_cast<char **>(&ibuf), &ilen, &obuf, &olen)

follow line is acceptable.

     if (iconv(ic, (const char **)(&ibuf), &ilen, &obuf, &olen)

Please change that line or fix it in another way.

Original issue reported on code.google.com by [email protected] on 20 Sep 2010 at 2:58
@yukawa
Copy link
Collaborator

yukawa commented May 4, 2015

Just FYI, this is indeed an issue in FreeBSD side. See FreeBSD PR 199099, which was recently fixed.

@yukawa
Copy link
Collaborator

yukawa commented Nov 14, 2015

Reopening as this can be fixed in conjunction with #252.

@yukawa yukawa reopened this Nov 14, 2015
@yukawa yukawa closed this as completed in 766685b Nov 15, 2015
yukawa added a commit that referenced this issue Jul 24, 2016
@yukawa
Remove an obsolete OS_ANDROID rule
0804acf 
This is a follow up CL to 766685b,
which got rid of the dependency on iconv.

Even though we do not have any plan to use mozc::EncodingUtil in Android
build, in theory this class is compatible with Android.  Hence having
OS_ANDROID does not make sense anymore.

BUG=#27,#252
TEST=
REF_BUG=
REF_CL=107354157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated OpSys-FreeBSD Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yukawa @GoogleCodeExporter