Deprecate scoped_ptr. #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2015 22:02
With this CL, scoped_ptr is replaced with std::unique_ptr in the following directories. - src/android/ - src/base/ - src/config/ - src/data_manager/ - src/dictionary/ - src/ipc/ - src/testing/ This is just a mechanical refactoring. No behavior change is intended. BUG=#219 TEST=unittest REF_BUG=9164610 REF_CL=85302962,85303257,85303597,85305350,85305985,85306371,85309721,85312175,85315394
This CL removes scoped_ptr.h, which is no longer used. This is just a removal of an unused file. No behavior change is intended. BUG=#219 TEST=unittest REF_BUG=9164610 REF_CL=85316226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this series of CLs,
scoped_ptris going to be deprecated and completely replaced withstd::unique_ptr.No behavior change is intended.
Closes #219.