Google sync #627
Merged
Google sync #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also deletes an obsolete test that I happened to notice. PiperOrigin-RevId: 322223756
I managed to cause a lot of crashes with my filtering fix yesterday =/ PiperOrigin-RevId: 322429418
We previously made type(self) return Any in __init__ to avoid spurious errors about a class being non-instantiable. Copies the workaround to __class__. PiperOrigin-RevId: 322429519
PiperOrigin-RevId: 322599333
PiperOrigin-RevId: 322599520
PiperOrigin-RevId: 322806644
Fixes a bug where a type alias containing a type parameter that is used in both a generic class and a generic function would have its scope changed, messing up the type parameter count we use to report the "Appears only once in the signature" invalid-annotation error. PiperOrigin-RevId: 322919782
We can't resolve these properly, but for some reason people have been trying to use them a lot in typeshed recently, so let's set these aliases to Any for now. For #612. PiperOrigin-RevId: 323060647
PiperOrigin-RevId: 323074844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.