Google sync #639
Merged
Google sync #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently only works within a file; in the following code: Foo = Union[T, List[T]] x: Foo[int] the generated pyi code will contain Foo = Any x: Union[int, List[int]] that is, concrete instantiations of the alias will be correctly used and exported, but the alias itself will not be exported. PiperOrigin-RevId: 324293324
PiperOrigin-RevId: 324641138
The CL to support Union type macros caused a bizarre bug where
Union.set_slot('__getitem__') calls getattribute(Union, '__getitem__'),
creating an extra node, causing convert_class_annotations for a tuple
annotation containing a forward referenced imported type to be evaluated at the
wrong node, leading to the generation of an extra late annotation for the
imported module, finally producing "Invalid type annotation '<instance of
module>': Not a type" errors all over the place for pb2 enum annotations, since
those always have to be quoted. I resolved this by special-casing
Union.__getitem__ in attribute.py, so the extra node is not generated.
I also noticed that the type macro CL produced a corner case where
Union.getitem_slot is indistinguishable from calling __getitem__ on a Union's
options when a value is annotated as Type[Union[C1, C2, ...]] (but *not* when
the annotation is Union[Type[C1], Type[C2], ...]!). The inferred type is still
correct, if imprecise, so I just documented this behavior in a test rather than
trying to fix it.
PiperOrigin-RevId: 324684760
PiperOrigin-RevId: 324891454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.