Move JS dependencies required to build assets into their own workspace #10321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
|
Build files for 6ef79f8 have been deleted. |
…bpack-and-blocks.
aaemnnosttv
reviewed
Mar 5, 2025
package.json
Outdated
| @@ -48,9 +48,6 @@ | |||
| "install-global-npm": "npm install -g [email protected]", | |||
| "postinstall": "patch-package" | |||
There was a problem hiding this comment.
We need to include the patch-package config + handling here as well, no?
There was a problem hiding this comment.
We don't seem to have any config for patch-package, it just applies the patches in {repo root}/patches.
Actually, we do have a minor hiccup there in that we have a PHP patch in that directory that that patch-package complains about, it's just a warning but we should fix it. I'll create an issue for it.
techanvil
force-pushed
the
infra/10092-npm-workspaces-assets
branch
from
97c0ffe to
7f1f41e
Compare
19 tasks
eugene-manuilov
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Thanks, @techanvil. Looks mostly good but there are some things that we need to fix before moving on.
assets/blocks/reader-revenue-manager/block-editor-plugin/SettingPanel.js
Outdated
Show resolved
Hide resolved
Removed: - @popperjs/core - @react-hook/window-size Added: - @react-hook/event - @react-hook/throttle These added packages were needed as they were previously provided by @react-hook/window-size.
|
Thanks for the review, @eugene-manuilov! I've addressed your comments. Back over to you. |
eugene-manuilov
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
As discussed in Slack, I've included moving webpack config for the build scripts, and the
blocksfolder intoassets/in this PR.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist