-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Authorization Flow | Editor #400
Conversation
@swissspidy I just updated the plugin reset test here as I've seen it fail a bit randomly due to a short expect timeout on a few other PRs builds. Upon reviewing this test, I found that we could make it much better by using some of these new utility routes to apply the setup in the DB to more accurately test a real reset. Previously when resetting, you would end up on step 4 due to the utility plugins in use forcing the auth/verification state via filters. Now it tests that you end up on step 1 of the set up after resetting and added a waitForSelector as well to eliminate the issue we were having before. |
…e-auth-flow-editor
@swissspidy I just pushed some updates to see how they run on Travis - something weird is happening in my local but it doesn't seem to be related to these changes. |
While I was not able to reproduce these issues with the tests locally, I noticed that the backstop tests fail on Travis while they pass locally... 🤔 |
Passes now 🤷♂ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excited about this change! Not only does it add a nice little e2e test for the auth flow as an editor, it also drastically improves the e2e setup as a whole and introduces a nice set of utilities for these tests as well. 🎉 💪
Oh, and it also fixes the unstable plugin reset test 🙂
Let's merge this, and then see from there.
Summary
This PR is the first of the e2e tests that cover users other than the default (admin) user. As such it contains some foundational changes to the environment to install additional users, and utilities which will be useful in similar cases.
Addresses issue #256
Relevant technical choices
admin-2
,editor
,author
,contributor
Checklist