-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ingesting datasets having multiple dimensions in earth engine #492
Open
kbp45-cusp
wants to merge
9
commits into
google:main
Choose a base branch
from
kbp45-cusp:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j9sh264
reviewed
Jan 30, 2025
j9sh264
reviewed
Jan 30, 2025
j9sh264
reviewed
Jan 30, 2025
j9sh264
reviewed
Jan 30, 2025
j9sh264
reviewed
Jan 30, 2025
j9sh264
reviewed
Jan 30, 2025
j9sh264
reviewed
Jan 30, 2025
j9sh264
reviewed
Jan 30, 2025
j9sh264
reviewed
Jan 30, 2025
j9sh264
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial pass comments.
j9sh264
reviewed
Feb 3, 2025
j9sh264
reviewed
Feb 3, 2025
j9sh264
reviewed
Feb 3, 2025
j9sh264
reviewed
Feb 3, 2025
j9sh264
reviewed
Feb 3, 2025
j9sh264
reviewed
Feb 4, 2025
j9sh264
reviewed
Feb 4, 2025
j9sh264
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #305
Solution approach:
As the dataset contains multiple dimensions apart from latitude and longitude, we need to convert the data arrays to 2D grids. Hence We need to remove the all other dimensions. So, we are going to accept a list of dimension from user, on which we will partition the data. There might be cases when user don't want to partition the data on the basis of all dimensions. In such cases, the remaining dimensions will be flattened out and final grid will be of 2D. Also, we need to allow user to specify the name of the resulting COGs based on the partitioned dimensions.
Key notes for each cli arguments: