Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[derive] Document trivial_is_bit_valid #1905

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Oct 14, 2024

Explain why we only support concrete types so that future authors won't spuriously add support for them.

@joshlf joshlf requested a review from jswrenn October 14, 2024 14:31
@joshlf joshlf enabled auto-merge October 14, 2024 14:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.33%. Comparing base (c128ed2) to head (67b4504).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1905   +/-   ##
=======================================
  Coverage   87.33%   87.33%           
=======================================
  Files          16       16           
  Lines        5960     5960           
=======================================
  Hits         5205     5205           
  Misses        755      755           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Explain why we only support concrete types so that future authors won't
spuriously add support for them.
@joshlf joshlf force-pushed the trivial-is-bit-valid-docs branch from 6afc462 to 67b4504 Compare October 14, 2024 14:44
@joshlf joshlf added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 967b3a0 Oct 14, 2024
63 checks passed
@joshlf joshlf deleted the trivial-is-bit-valid-docs branch October 14, 2024 15:38
google-pr-creation-bot pushed a commit to google-pr-creation-bot/zerocopy that referenced this pull request Feb 24, 2025
Explain why we only support concrete types so that future authors won't
spuriously add support for them.
joshlf added a commit to google-pr-creation-bot/zerocopy that referenced this pull request Feb 24, 2025
Explain why we only support concrete types so that future authors won't
spuriously add support for them.
github-merge-queue bot pushed a commit that referenced this pull request Feb 24, 2025
Explain why we only support concrete types so that future authors won't
spuriously add support for them.

Co-authored-by: Joshua Liebow-Feeser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants