[pointer] Simplify AliasingSafe, rename to Read #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
approved these changes
Oct 14, 2024
joshlf
force-pushed
the
aliasing-safety-is-read
branch
from
329d0c2 to
a982e1d
Compare
joshlf
force-pushed
the
aliasing-safety-is-read
branch
2 times, most recently
from
d510cff to
c938064
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1908 +/- ##
==========================================
+ Coverage 87.64% 87.66% +0.02%
==========================================
Files 17 17
Lines 5956 5968 +12
==========================================
+ Hits 5220 5232 +12
Misses 736 736 ☔ View full report in Codecov by Sentry. |
`AliasingSafe` is really about whether a pointer permits unsynchronized reads - either because the referent contains no `UnsafeCell`s or because the aliasing mode is `Exclusive`. Previously, `AliasingSafe` was not named consistent with this meaning, and was a function of a *pair* of types rather than of a single type. This commit fixes both oversights. While we're here, we also add `Read` bounds in some places, allowing us to simplify many safety comments.
joshlf
force-pushed
the
aliasing-safety-is-read
branch
from
c938064 to
3e67424
Compare
joshlf
added a commit
that referenced
this pull request
Feb 24, 2025
`AliasingSafe` is really about whether a pointer permits unsynchronized reads - either because the referent contains no `UnsafeCell`s or because the aliasing mode is `Exclusive`. Previously, `AliasingSafe` was not named consistent with this meaning, and was a function of a *pair* of types rather than of a single type. This commit fixes both oversights. While we're here, we also add `Read` bounds in some places, allowing us to simplify many safety comments. gherrit-pr-id: I88b9101a614459af3b062dc3d38142ba76427f34
|
Backporting in #2383 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
`AliasingSafe` is really about whether a pointer permits unsynchronized reads - either because the referent contains no `UnsafeCell`s or because the aliasing mode is `Exclusive`. Previously, `AliasingSafe` was not named consistent with this meaning, and was a function of a *pair* of types rather than of a single type. This commit fixes both oversights. While we're here, we also add `Read` bounds in some places, allowing us to simplify many safety comments. gherrit-pr-id: I88b9101a614459af3b062dc3d38142ba76427f34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AliasingSafeis really about whether a pointer permits unsynchronized reads - either because the referent contains noUnsafeCells or because the aliasing mode isExclusive. Previously,AliasingSafewas not named consistent with this meaning, and was a function of a pair of types rather than of a single type. This commit fixes both oversights.While we're here, we also add
Readbounds in some places, allowing us to simplify many safety comments.