Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/godocfx): retry go get with explicit envoy dependency #11564

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Feb 5, 2025

This is a bit of a hack. Alternatively, we could capture stderr and check for the ambiguous import string before retrying.

This gets around errors of the form:

        github.com/envoyproxy/go-control-plane/envoy/type/matcher/v3: ambiguous import: found package github.com/envoyproxy/go-control-plane/envoy/type/matcher/v3 in multiple modules:

I confirmed this works by running it locally (fails before this commit, succeeds after):

go run . cloud.google.com/go/bigquery

I also removed the now-deprecated -d flag.

@tbpg tbpg requested a review from a team as a code owner February 5, 2025 19:29
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Feb 5, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit a06a6a5 into googleapis:main Feb 5, 2025
5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants