fix(firestore): Enable '!=' operator for 'nil' and 'NaN'; correct handling of '!= nil' filters #11639 #11649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanbiv
commented
Feb 24, 2025
sanbiv
commented
- Resolved invalid results for '!= nil' queries: Corrected the logic to ensure that queries using '!= nil' return valid results.
- Enabled '!= NaN' queries: Modified the query parser to support '!= NaN' conditions.
- Fixed test expecting identical results for '== null' and '!= null': Updated the test to accurately reflect the differing expected outcomes for these queries.
- Added test for '!= NaN' query: Introduced a new test case to verify the correct handling of '!= NaN' queries.
…s when filtering by != nil
product-auto-label
bot
added
the
api: firestore
bhshkh
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.