Add conditional for OT features #11
Comments
|
OK, I've done this, and the way to use it is: - check: no_orphaned_marks
input:
text: aasaea᷆a᷇a᷆a᷇e᷆e᷇e᷆e᷇ɛ́ɛ̀ɛ̂ɛ̌ɛ̄ɛ᷆ɛ᷇ɛ᷆ɛ᷇...
features:
smcp: true
conditions:
features:
- smcp |
NeilSureshPatel
added a commit
to NeilSureshPatel/shaperglot
that referenced
this issue
Feb 6, 2023
* Update checker.py Added mark2base test that uses the serialized buffer to see if a mark has a GPOS shift if placed after a target base mark. * Use shaper to check whether glyphs exist, see googlefonts#7 * Add youseedee to requirements * Fix some lints * Read your own config file, pylint * More pylint fixes * Pin protobuf dependency * Further poetry dependency fixes * Cache shaping * Fix error message * Implement an "unknown" state * Implement the "report" option * Speed up the mark checker * Don't GSUB closure on pathological fonts * Make pylint happier * Make result status machine readable * A new test for unencoded glyph variants. Fixes googlefonts#8 * Use the language tag from the language we're checking * Skip tests based on certain conditions (missing features), fixes googlefonts#11 * Make linter happier * Update orthographies check to include auxiliary chars There is probably a more elegant way to implement this but I have merged auxiliary characters into the bases for the orthographies check. For the purposes of language support testing base and auxiliary characters need to be included to ensure loan words, names and place names can all be typed for a given language. * Improve error messages * Add Neil's work * Pylint stuff * Update shaping_differs.py Fixed Type Error caused by trying to concat YAML to str * Make non-verbose less verbose * Transfer IP to Google --------- Co-authored-by: Simon Cozens <[email protected]> Co-authored-by: Dave Crossland <[email protected]>
NeilSureshPatel
added a commit
to NeilSureshPatel/shaperglot
that referenced
this issue
Mar 14, 2023
* Update checker.py Added mark2base test that uses the serialized buffer to see if a mark has a GPOS shift if placed after a target base mark. * Use shaper to check whether glyphs exist, see googlefonts#7 * Add youseedee to requirements * Fix some lints * Read your own config file, pylint * More pylint fixes * Pin protobuf dependency * Further poetry dependency fixes * Cache shaping * Fix error message * Implement an "unknown" state * Implement the "report" option * Speed up the mark checker * Don't GSUB closure on pathological fonts * Make pylint happier * Make result status machine readable * A new test for unencoded glyph variants. Fixes googlefonts#8 * Use the language tag from the language we're checking * Skip tests based on certain conditions (missing features), fixes googlefonts#11 * Make linter happier * Update orthographies check to include auxiliary chars There is probably a more elegant way to implement this but I have merged auxiliary characters into the bases for the orthographies check. For the purposes of language support testing base and auxiliary characters need to be included to ensure loan words, names and place names can all be typed for a given language. * Improve error messages * Add Neil's work * Pylint stuff * Update shaping_differs.py Fixed Type Error caused by trying to concat YAML to str * Make non-verbose less verbose * Transfer IP to Google --------- Co-authored-by: Simon Cozens <[email protected]> Co-authored-by: Dave Crossland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently when checking for orphaned marks with smcp activate it will return the results for the original list of glyphs if the font does not have an smcp feature defined. This is giving duplicate errors since we am also checking for orphaned marks for original forms.
The text was updated successfully, but these errors were encountered: