Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New message to be able to commit chunks and update the record's properties simultaneously #401

Closed
ghost opened this issue Oct 14, 2022 · 0 comments · Fixed by #402
Closed

Comments

@ghost
Copy link

ghost commented Oct 14, 2022

Is your feature request related to a problem? Please describe.
Too many writes on entities when committing chunks since we need to commit the upload and at the same time modify the record.

Describe the solution you'd like
At the end of uploading chunks, our gRPC client is using two messages: CommitChunk and UpdateRecord. The first function modify both the blob and record entities, and the second, the record entities. We suspect that this generates too many writes on entities. We would like a function that combines these operations.

Describe alternatives you've considered
Alternatives: perform the second calls asynchronously with a delay in a goroutine or by managing a queue of updates to perform. But I do not like the idea of introducing potential data inconsistency in our solution.

Additional context

hongalex added a commit that referenced this issue Oct 26, 2022
* feat: add CommitChunkedUploadWithUpdateRecord method

* update comments

* fix: validate record signature before updateing timestamp

* chore: add record as optional field to CommitChunkedUpload (#401)

* chore: address PR review related to unit tests

Co-authored-by: Frederic Loranger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants