Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a state machine to Blob #101

Merged
merged 1 commit into from
Aug 21, 2020
Merged

feat: Add a state machine to Blob #101

merged 1 commit into from
Aug 21, 2020

Conversation

yuryu
Copy link
Member

@yuryu yuryu commented Aug 14, 2020

What type of PR is this?
/kind feat

What this PR does / Why we need it:
This adds transition methods to Blob to implement a state machine for BlobStatus. This is for #83.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@yuryu yuryu requested a review from hongalex August 14, 2020 23:53
@yuryu yuryu self-assigned this Aug 14, 2020
@yuryu yuryu linked an issue Aug 15, 2020 that may be closed by this pull request
@yuryu yuryu added this to the alpha2 milestone Aug 15, 2020
@yuryu yuryu requested a review from a user August 15, 2020 02:31
Copy link
Collaborator

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor nits

@yuryu yuryu merged commit d296b01 into master Aug 21, 2020
@yuryu yuryu deleted the blob-state branch August 21, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Implement Blob management
3 participants