fix: make create/update methods return new resource #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongalex
force-pushed
the
fix-create-update
branch
from
fe4a62c to
a2280ae
Compare
yuryu
reviewed
Aug 31, 2020
yuryu
suggested changes
Sep 1, 2020
|
Also I think this is more of a bug fix or feature request rather than a refactor as it changes the behavior of the program. |
hongalex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind refactor
What this PR does / Why we need it:
For
StoresandRecords,CreateandUpdatemethods should return the newly created resource. While the RPC is already followingthis best practice, the underlying methods in
metadband its implementations are not following this.Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: