Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Iris Ho: adding cronjob option for collector #286

Merged
merged 5 commits into from Aug 25, 2021
Merged

feat: Iris Ho: adding cronjob option for collector #286

merged 5 commits into from Aug 25, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2021

/kind feat

What this PR does / Why we need it:
Cron job for running the collector every day at 12:10am.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
Note that users will need to edit the env var values.

** Author
This contribution was originally made by Iris Ho. I am simply applying the changes on her behalf using my account.

@google-cla
Copy link

google-cla bot commented Aug 24, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Aug 24, 2021
@google-cla
Copy link

google-cla bot commented Aug 24, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ghost
Copy link
Author

ghost commented Aug 25, 2021

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Aug 25, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ghost
Copy link
Author

ghost commented Aug 25, 2021

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Aug 25, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ghost
Copy link
Author

ghost commented Aug 25, 2021

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Aug 25, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 25, 2021
@ghost
Copy link
Author

ghost commented Aug 25, 2021

@googlebot I fixed it.

@ghost ghost requested a review from timlynch2k August 25, 2021 19:56
@ghost ghost dismissed timlynch2k’s stale review August 25, 2021 19:56

The review has been addressed, and the container image name has been updated.

@ghost ghost removed the request for review from timlynch2k August 25, 2021 19:57
@ghost ghost assigned timlynch2k Aug 25, 2021
@timlynch2k timlynch2k merged commit c139cd7 into googleforgames:main Aug 25, 2021
@ghost ghost deleted the collector-cron-job branch September 24, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants