Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support CRC32C and MD5 checksums #309

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

yuryu
Copy link
Member

@yuryu yuryu commented Oct 1, 2021

What type of PR is this?
/kind feat

What this PR does / Why we need it:
This PR implements the checksum support with CRC32C and MD5.

Which issue(s) this PR fixes:

Closes #292

Special notes for your reviewer:

@yuryu yuryu added the enhancement New feature or request label Oct 1, 2021
@yuryu yuryu added this to the v0.2.0-beta3 milestone Oct 1, 2021
@yuryu yuryu requested review from hongalex and a user October 1, 2021 00:59
@yuryu yuryu self-assigned this Oct 1, 2021
@google-cla google-cla bot added the cla: yes label Oct 1, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yuryu yuryu merged commit fbb26a0 into googleforgames:main Oct 1, 2021
@yuryu yuryu deleted the feat/checksums-meta branch October 1, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MD5 Checksum
1 participant