Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return chunk size and count with GetRecord #312

Merged
5 commits merged into from
Oct 5, 2021

Conversation

yuryu
Copy link
Member

@yuryu yuryu commented Oct 5, 2021

What type of PR is this?
/kind fix

What this PR does / Why we need it:
This PR fixes a bug where the number of chunks and chunk size in the Record message were not correctly populated.

Which issue(s) this PR fixes:

Closes #310

Special notes for your reviewer:
This work is based on #311.

@google-cla google-cla bot added the cla: yes label Oct 5, 2021
@yuryu yuryu requested review from hongalex and a user October 5, 2021 05:02
@yuryu yuryu self-assigned this Oct 5, 2021
@yuryu yuryu added this to the v0.2.0-beta3 milestone Oct 5, 2021
@vasconcelosvcd
Copy link
Collaborator

LGTM

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost ghost merged commit e13ce25 into googleforgames:main Oct 5, 2021
@yuryu yuryu deleted the fix/return-chunk-size branch October 5, 2021 21:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chunked and NumberOfChunked are not saved in the Datastore
2 participants