feat: support redis pool config from file #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
requested review from
|
Can we split this PR into a few different pieces?
I've also added a few more inline comments. |
yuryu
suggested changes
Mar 7, 2022
|
/gcbrun |
|
/gcbrun |
yuryu
reviewed
Mar 7, 2022
hongalex
approved these changes
Mar 7, 2022
|
/gcbrun |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feat Enable configuration to be read from a file (yaml, using viper) or environment variable; add the ability to set the Redis pool Idle Timeout to mitigate broken pipe issues.
What this PR does / Why we need it:
Override redis pool configuration using viper to read yaml file or from environment variable.
Which issue(s) this PR fixes:
Closes #324
Closes #
Special notes for your reviewer: