feat!: migrate to go-redis as redis client #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuryu
approved these changes
Mar 17, 2022
yuryu
changed the title
|
Also this breaking change is fine because we didn't release the previous behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind refactor
What this PR does / Why we need it:
Migrates current client from redigo to go-redis
BREAKING: redigo and go-redis options are NOT compatible. The following options have been modified.
DROPPED
redis_pool_maxIdle
redis_pool_wait
CHANGED
redis_pool_minActive -> redis_pool_size
redis_pool_idleTimeout -> redis_idle_timeout
ADDED
redis_min_idle_conns
redis_max_retries
redis_min_retry_backoff
redis_max_retry_backoff
Which issue(s) this PR fixes:
Closes #333
Special notes for your reviewer: