feat: query limit support #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuryu
reviewed
Jun 10, 2022
api/open_saves.proto
Outdated
| @@ -360,6 +360,9 @@ message QueryRecordsRequest { | |||
| // List of sort orders to return records. These SortOrders are applied | |||
| // in sequence. | |||
| repeated SortOrder sort_orders = 5; | |||
|
|
|||
| // the limit of the number of records to return. | |||
| int64 limit = 6; | |||
There was a problem hiding this comment.
I think int32 makes more sense here because you're casting limit to int later, which could be 32 bits on some platforms. Also I don't think we'd ever use a limit bigger than 2 billion.
yuryu
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feat
What this PR does / Why we need it:
Adds the ability to limit the number of records returned by
QueryRecordsWhich issue(s) this PR fixes:
Updates #341
Fixes #339
Special notes for your reviewer:
Also refactors the argument of QueryRecords to take in the QueryRecordRequest struct rather than individual parameters