feat: chunk count checking #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch supports check count checking when committing. The client can optionally set chunk_count when uploading and if set, the server will check if the uploaded chunk count matches the value. It returns FailedPrecondition if it doesn't.
hongalex
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feat
What this PR does / Why we need it:
This patch supports chunk count checking when committing.
The client can optionally set chunk_count when uploading and if set,
the server will check if the uploaded chunk count matches
the value. It returns FailedPrecondition if it doesn't.
Which issue(s) this PR fixes:
Closes #313
Special notes for your reviewer: