feat: make max inline blob size configurable

configs/service.yaml

@@ -11,4 +11,6 @@ redis_pool_size: 10000
 redis_idle_timeout: 0
 redis_max_retries: 3
 redis_min_retry_backoff: "8ms"
-redis_max_retry_backoff: "512ms"
+redis_max_retry_backoff: "512ms"
+
+blob_max_inline_size: 65536

internal/app/server/open_saves.go

@@ -42,7 +42,6 @@ import (
 // TODO(hongalex): make this a configurable field for users.
 const (
 	maxRecordSizeToCache int = 10 * 1024 * 1024       // 10 MB
-	maxInlineBlobSize    int = 64 * 1024              // 64 KiB
 	streamBufferSize     int = 1 * 1024 * 1024        // 1 MiB
 	chunkSizeLimit       int = 1 * 1024 * 1024 * 1024 // 1 GiB
 )
@@ -52,6 +51,7 @@ type openSavesServer struct {
 	blobStore  blob.BlobStore
 	metaDB     *metadb.MetaDB
 	cacheStore *cache.Cache
+	config.ServiceConfig
 
 	pb.UnimplementedOpenSavesServer
 }
@@ -78,10 +78,11 @@ func newOpenSavesServer(ctx context.Context, cfg *config.ServiceConfig) (*openSa
 		}
 		cache := cache.New(redis.NewRedisWithConfig(&cfg.RedisConfig), &cfg.CacheConfig)
 		server := &openSavesServer{
-			cloud:      cfg.ServerConfig.Cloud,
-			blobStore:  gcs,
-			metaDB:     metadb,
-			cacheStore: cache,
+			cloud:         cfg.ServerConfig.Cloud,
+			blobStore:     gcs,
+			metaDB:        metadb,
+			cacheStore:    cache,
+			ServiceConfig: *cfg,
 		}
 		return server, nil
 	default:
@@ -396,8 +397,7 @@ func (s *openSavesServer) CreateBlob(stream pb.OpenSaves_CreateBlobServer) error
 	log.Debugf("Got metadata from stream: store(%s), record(%s), blob size(%d)\n",
 		meta.GetStoreKey(), meta.GetRecordKey(), meta.GetSize())
 
-	// TODO(yuryu): Make the threshold configurable
-	if meta.GetSize() <= int64(maxInlineBlobSize) {
+	if meta.GetSize() <= int64(s.BlobConfig.MaxInlineSize) {
 		return s.insertInlineBlob(ctx, stream, meta)
 	}
 	return s.insertExternalBlob(ctx, stream, meta)

internal/pkg/config/loader.go

@@ -122,9 +122,14 @@ func Load(path string) (*ServiceConfig, error) {
 		IdleTimeout:     time.Duration(viper.GetUint(RedisIdleTimeout)) * time.Second,
 	}
 
+	blobConfig := BlobConfig{
+		MaxInlineSize: viper.GetInt(BlobMaxInlineSize),
+	}
+
 	return &ServiceConfig{
 		ServerConfig: serverConfig,
 		CacheConfig:  cacheConfig,
 		RedisConfig:  redisConfig,
+		BlobConfig:   blobConfig,
 	}, nil
 }

internal/pkg/config/model.go

@@ -32,12 +32,15 @@ const (
 	RedisMaxRetries      = "redis_max_retries"
 	RedisMinRetryBackoff = "redis_min_retry_backoff"
 	RedisMaxRetryBackoff = "redis_max_retry_backoff"
+
+	BlobMaxInlineSize = "blob_max_inline_size"
 )
 
 type ServiceConfig struct {
 	ServerConfig
 	CacheConfig
 	RedisConfig
+	BlobConfig
 }
 
 // ServerConfig defines common fields needed to start Open Saves.
@@ -66,3 +69,8 @@ type RedisConfig struct {
 	PoolSize     int
 	IdleTimeout  time.Duration
 }
+
+// BlobConfig has Open Saves blob related configurations.
+type BlobConfig struct {
+	MaxInlineSize int
+}