feat: bundle grpc_health_probe in image #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Sep 10, 2022
| RUN GRPC_HEALTH_PROBE_VERSION=v0.4.12 && \ | ||
| wget -qO/bin/grpc_health_probe https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/${GRPC_HEALTH_PROBE_VERSION}/grpc_health_probe-linux-amd64 && \ | ||
| chmod +x /bin/grpc_health_probe | ||
|
|
||
| # Build the server image. |
There was a problem hiding this comment.
The executable should probably be packaged in both the collector and the server.
For the collector, I would add this section at line 62 and line 78 in the original file, and keep the CMD as the last step.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feat
What this PR does / Why we need it:
Bundles the statically compiled grpc_health_probe in the container image.
Which issue(s) this PR fixes:
Closes #386
Special notes for your reviewer: