-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: remove indexing for timestamps #399
fix!: remove indexing for timestamps #399
Conversation
The tests that are failing are only part of the collector and they are failing on main as well. |
Fixed the failing collector tests. PTAL @loranger2k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
We may want to eventually update the index.yaml examples to use the record key as a prefix to follow best practices and discourage the use of monotonically increasing properties are strongly discouraged.
What type of PR is this?
What this PR does / Why we need it:
Removes indexing for all timestamps since it breaks best practices around monotonically increasing values.
Which issue(s) this PR fixes:
Special notes for your reviewer:
This requires changes on the Open Saves collector, which previously depended on the use of the Timestamps fields to select entities older than a certain time. Now, we fetch all blobs/chunks with a status and only selectively delete.
This is also a breaking change to
QueryRecords
since we will no longer support querying by ascending/descending timestamps.