Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable opencensus tracing with cloud trace for datastore #400

Merged
6 commits merged into from
Oct 14, 2022

Conversation

hongalex
Copy link
Collaborator

@hongalex hongalex commented Oct 14, 2022

What type of PR is this?

/kind feat

What this PR does / Why we need it:
Enables the default tracing provided by the Datastore client library, exporting to Cloud Trace. This allows us to view spans created by the Datastore client for transactions, viewing latency and some error metrics.

This change is EXPERIMENTAL and subject to change or removal without notice.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@hongalex hongalex requested review from a user and yuryu October 14, 2022 06:58
Copy link
Member

@yuryu yuryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ghost ghost merged commit 363ee90 into main Oct 14, 2022
@ghost ghost deleted the enable-opencensus-tracing branch October 14, 2022 15:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants