feat: use google.rpc.Status #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the standard google.rpc.Status in GetRecordsResponse instead of the custom defined proto. This is a backward-compatible change at the proto level.
ghost
reviewed
Nov 17, 2022
| Record: protoRec, | ||
| StoreKey: storeKey, | ||
| Status: pbStatus, | ||
| Record: rec.ToProto(), |
There was a problem hiding this comment.
Really nice simplification of the logic with the use of the Status from grpc and changes in the record.Record functions (to test for nil).
ghost
approved these changes
Nov 17, 2022
| @@ -0,0 +1,3 @@ | |||
| [submodule "third_party/googleapis"] | |||
| path = third_party/googleapis | |||
| url = https://github.com/googleapis/googleapis.git | |||
There was a problem hiding this comment.
Glad to see that importing the proto file this way works! In my previous attempts, I copied the file from googleapis locally in api/google/grpc/status.proto but had issues with the server code that was serializing the response at runtime.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feat
What this PR does / Why we need it:
Use the standard google.rpc.Status in GetRecordsResponse instead of the custom defined proto for better interoperability with the gRPC Go library.
This is a backward-compatible change at the proto level.
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: