Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurations for keep alive on grpc server #416

Merged
3 commits merged into from
Jan 10, 2023

Conversation

vasconcelosvcd
Copy link
Collaborator

@vasconcelosvcd vasconcelosvcd commented Jan 9, 2023

What type of PR is this?
/kind fix

What this PR does / Why we need it:
Add possibility to configure server keep alive parameters.

Which issue(s) this PR fixes:
Closes #415

Special notes for your reviewer:

@vasconcelosvcd vasconcelosvcd requested review from hongalex and a user January 9, 2023 18:11
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to keep the config consistent for duration values.

@vasconcelosvcd vasconcelosvcd marked this pull request as ready for review January 9, 2023 23:36
@vasconcelosvcd vasconcelosvcd requested a review from a user January 9, 2023 23:36
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost ghost merged commit 2c9b544 into googleforgames:main Jan 10, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide configurable defaults for gRPC Server Parameters
2 participants