Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement store caching #441

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

vasconcelosvcd
Copy link
Collaborator

What type of PR is this?

/kind feat

What this PR does / Why we need it:

This PR enables store caching.

Which issue(s) this PR fixes:

Closes #404

Special notes for your reviewer:
Since I'm not able to run the full test scenario in the gcp project I'm relying on the CI or someone to manually run it

@vasconcelosvcd vasconcelosvcd added the enhancement New feature or request label Mar 24, 2024
@vasconcelosvcd vasconcelosvcd requested review from lorangf, hongalex and a user March 24, 2024 00:22
@vasconcelosvcd vasconcelosvcd changed the title Feat/store caching feat: implement store caching Mar 24, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks with store key name and logs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasconcelosvcd vasconcelosvcd merged commit cec9788 into googleforgames:main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add caching for Store entities
1 participant