-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump Up datastore dep to v1.17.0 and Golang version to 1.21 #446
Conversation
/gcbrun |
From the go.mod:
The build container is complaining about an invalid statement with toolchain:
I suspect that we will need to ask google to create a new build container with the 1.21 golang version and toolchain for the CI pipeline to pass. |
@loranger2k @Zurvarian I think it's a matter of upgrading the cloudrun job file here |
Thanks for the updates, I missed the builder part. Indeed the toolchain is a new feature from Golang 1.21 on-wards, meant to fix the exact version the code must be compiled with. Once we have a compatible builder I'll update the file mentioned by @vasconcelosvcd |
@Zurvarian just updated the golang builder to 1.21. I think you will also need to update the Then we can retry the build |
/gcbrun |
1 similar comment
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/gcbrun |
What type of PR is this?
/kind feat
What this PR does / Why we need it:
It increases the version of the Datastore dependency to v1.17.0 and Golang version to 1.21
This required to have access to Datastore traces in OpenTelemetry.
Which issue(s) this PR fixes:
Closes #445
Special notes for your reviewer:

Tested locally, here is an example of the new traces being exposed.
Note that sensible details have been removed.