cmd/govim: add config ExperimentalTempModfile #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
cmd_govim_add_config_to_disable_temp_modfile
branch
2 times, most recently
from
d0001d5 to
d572fdd
Compare
myitcv
changed the title
myitcv
force-pushed
the
cmd_govim_add_config_to_disable_temp_modfile
branch
2 times, most recently
from
fba3769 to
61b8c76
Compare
myitcv
force-pushed
the
cmd_govim_add_config_to_disable_temp_modfile
branch
3 times, most recently
from
3f276b6 to
b32d0d3
Compare
myitcv
force-pushed
the
cmd_govim_add_config_to_disable_temp_modfile
branch
2 times, most recently
from
56fd2b4 to
79358f9
Compare
myitcv
changed the title
|
As you can see the test is skipped pending a fix in golang/go#36247. But merging the skipped test enables a fix to be more easily verified. |
leitzler
approved these changes
Jan 24, 2020
leitzler
reviewed
Jan 24, 2020
myitcv
force-pushed
the
cmd_govim_add_config_to_disable_temp_modfile
branch
from
79358f9 to
71fa618
Compare
|
Per comments above, this is now dependent on #713 |
ExperimentalTempModfile corresponds to the gopls config setting "tempModfile" which controls whether a temporary modfile is used in place of the main module's original go.mod file. When enabled, any user-initiated changes (to .go files) that would otherwise have resulted in changes to the original go.mod file, e.g. adding an import for a package whose module is not listed as a requirement, get raised as diagnostic warnings with suggested fixes which update the go.mod file. Add a test that locks in the current behaviour.
myitcv
force-pushed
the
cmd_govim_add_config_to_disable_temp_modfile
branch
from
71fa618 to
f24837a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.