RequestControllerTypedLink return subscription streams that can end

[warrenisarobot]

Update RequestControllerTypedLink so that it will not refetch and return the stream result directly. This allows the stream to end if the server completes the stream, and the listeners onData will fire.

Since the requestController stream never closes the switchMap's result stream will also never reach the onDone state. This uses only the first matching requestController emitted request when it is a subscription operation. This allows the switchMap's resulting stream to close when the server's response stream closes as well.

[netlify]

✅ Deploy Preview for ferry-gql ready!

Name	Link
🔨 Latest commit	ac7b0cd
🔍 Latest deploy log	https://app.netlify.com/sites/ferry-gql/deploys/67ae3a488c2c6800080ef9a6
😎 Deploy Preview	https://deploy-preview-629--ferry-gql.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[warrenisarobot]

Corresponding issue for this PR:

#630

[knaeckeKami]

Hi!

Please add a test that ensures that this new behavior will not break in the future.

should be something like

  group('done event for subscriptions', () {
    late TypedLink typedLink;

    setUp(() {
      typedLink = TypedLink.from([
        RequestControllerTypedLink(),
        TypedLink.function(<TData, TVars>(request, [next]) =>
            Stream<OperationResponse<TData, TVars>>.empty()),
      ]);
    });


    test('onDone is propagated for subscriptions', () {
      final stream = typedLink.request(
        JsonOperationRequest(
          fetchPolicy: FetchPolicy.NetworkOnly,
          vars: {},
          operation: Operation(
            document: gql.parseString(r'''
            subscription Sub {
                reviews {
                  id
                  stars
                }
            }'''),
          ),
        ),
      );

      expect(stream, emitsInOrder([emitsDone]));
    });
  });

[warrenisarobot]

Hi!

Please add a test that ensures that this new behavior will not break in the future.

should be something like

  group('done event for subscriptions', () {
    late TypedLink typedLink;

    setUp(() {
      typedLink = TypedLink.from([
        RequestControllerTypedLink(),
        TypedLink.function(<TData, TVars>(request, [next]) =>
            Stream<OperationResponse<TData, TVars>>.empty()),
      ]);
    });


    test('onDone is propagated for subscriptions', () {
      final stream = typedLink.request(
        JsonOperationRequest(
          fetchPolicy: FetchPolicy.NetworkOnly,
          vars: {},
          operation: Operation(
            document: gql.parseString(r'''
            subscription Sub {
                reviews {
                  id
                  stars
                }
            }'''),
          ),
        ),
      );

      expect(stream, emitsInOrder([emitsDone]));
    });
  });

I appreciate the example on this one! I added the test to validate that the RequestControllerTypedLink is passing along the stream done

[knaeckeKami]

Thanks!