[tempo-distributed] adds conditional ability to store tokengen output into k8s secret. #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrady
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
rbrady
force-pushed
the
rbrady/217968-adds-tokengen-secret-storage
branch
from
f98daaf to
4322a2a
Compare
Signed-off-by: Ryan Brady <[email protected]>
rbrady
force-pushed
the
rbrady/217968-adds-tokengen-secret-storage
branch
from
4322a2a to
b67d631
Compare
…cret storage for the token is not enabled by default Signed-off-by: Ryan Brady <[email protected]>
rbrady
force-pushed
the
rbrady/217968-adds-tokengen-secret-storage
branch
from
bc9442e to
8480186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds conditional capability to enterprise-traces to store tokengen output in a kubernetes secret to provide parity with Loki and Mimir. This allows other helm jobs to access the admin token for additional operations such as tenant provisioning.
Fixes: #deployment_tools/217968