[grafana] Process sidecar configmap/secret label and labelValue with tpl #3585
+35
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the sidecar configmap
label
andlabelValue
values to be processed withtpl
. This is a convenience feature for users with multiple Grafana helm releases installed to the same namespace.This would allow users to configure a common values file for multiple helm releases to the same namespace similar to:
This would allow users to not have to specify a unique
.sidecar.xyz.label(Value)
for each release's values file, but still retain the ability to dictate which releases should mount which configmaps by referencing the unique release names (or other templated value).A note: I attempted to follow the CONTRIBUTING.md guidelines which specified that helm-docs should be generated--I attempted to do so and most of the README was significantly altered, so I instead manually inserted the README changes. If this is improper please let me know and I can follow whatever procedure is expected.