Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] Process sidecar configmap/secret label and labelValue with tpl #3585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-abella
Copy link

This change modifies the sidecar configmap label and labelValue values to be processed with tpl. This is a convenience feature for users with multiple Grafana helm releases installed to the same namespace.

This would allow users to configure a common values file for multiple helm releases to the same namespace similar to:

sidecar:
  dashboards:
    label: 'load-for-{{ .Release.Name }}'

This would allow users to not have to specify a unique .sidecar.xyz.label(Value) for each release's values file, but still retain the ability to dictate which releases should mount which configmaps by referencing the unique release names (or other templated value).


A note: I attempted to follow the CONTRIBUTING.md guidelines which specified that helm-docs should be generated--I attempted to do so and most of the README was significantly altered, so I instead manually inserted the README changes. If this is improper please let me know and I can follow whatever procedure is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant