Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix build error with import uris #15

Closed
wants to merge 1 commit into from

Conversation

victorlcm
Copy link

Hey everyone,

I'm using this template for coding some libraries for my k6 tests and I've encountered an issue while trying to build when using imports from URIs like

import { randomIntBetween } from 'https://jslib.k6.io/k6-utils/1.1.0/index.js';

This PR aims to fix that by adding core-js and changing the external regex in webpack.config.js to anything that includes k6.

I've also included some scripts build and watch to improve developer experience

@victorlcm
Copy link
Author

Hey guys, can anyone help me with a review in this one? I could not add reviewers by editing the PR, sorry! @ppcano, @simskij

@ppcano ppcano self-requested a review June 7, 2021 15:00
@ppcano
Copy link
Collaborator

ppcano commented Jun 7, 2021

Hi Victor,

thank you for the PR and research on this issue.

I think it should be fixed by b4b8dee. Please, let me know otherwise.

Related issue #16

I've also included some scripts build and watch to improve developer experience

I rather let this project as a basic template to avoid being opinionated and let everyone extend on their own.

@ppcano ppcano closed this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants