Update mimirtool grafana analyze to support more panel types
#10669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… histogram, candlestick, canvas, flame graph, geomap, node graph, trend and XY chart panel types
tacole02
reviewed
Feb 17, 2025
56quarters
approved these changes
Feb 18, 2025
ying-jeanne
pushed a commit
that referenced
this pull request
Feb 19, 2025
* add support for custom panel types * add support for bar chart, pie chart, state timeline, status history, histogram, candlestick, canvas, flame graph, geomap, node graph, trend and XY chart panel types * add license header * update CHANGELOG * remove white noise * fix typo
ying-jeanne
pushed a commit
that referenced
this pull request
Feb 19, 2025
* add support for custom panel types * add support for bar chart, pie chart, state timeline, status history, histogram, candlestick, canvas, flame graph, geomap, node graph, trend and XY chart panel types * add license header * update CHANGELOG * remove white noise * fix typo
ying-jeanne
pushed a commit
that referenced
this pull request
Feb 20, 2025
* add support for custom panel types * add support for bar chart, pie chart, state timeline, status history, histogram, candlestick, canvas, flame graph, geomap, node graph, trend and XY chart panel types * add license header * update CHANGELOG * remove white noise * fix typo
ying-jeanne
pushed a commit
that referenced
this pull request
Feb 20, 2025
* add support for custom panel types * add support for bar chart, pie chart, state timeline, status history, histogram, candlestick, canvas, flame graph, geomap, node graph, trend and XY chart panel types * add license header * update CHANGELOG * remove white noise * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This pull request updates
mimirtool grafana analyzeto support the following panel types:At Maersk, our adaptive metrics solution uses
mimirtool grafana analyzeto determine whether a metric is referenced in a dashboard. We discovered that the command skips more than half of the panel types that can reference Prometheus metrics. This is problematic, as we don't want to drop or aggregate metrics that are used in a dashboard.The panel types in
pkg/mimirtool/minisdkwere unnecessarily complex with most of their fields being unused. Now, there is a singleminisdk.Paneltype that has only the fields that are used.Previously, the targets of a custom panel would always be skipped. Now,
mimirtoolwill include metrics from custom panels if the custom panel follows the same structure as normal panels of having atargetfield in the root panel JSON.The standalone
TestParseMetricsInBoardWithTimeseriesPaneltest has been merged with theTestParseMetricsInBoardtest which now tests all panel types in a single test.Checklist
Documentation added.CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.