Update PublishGuide to use Gradle AntBuilder #13622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion from Groovy
jamesfredley
changed the title
|
@jamesfredley Without having checked why this was a problem for |
|
@matrei I end up running into this working on grails-async and grails-docs last evening which both use PublishGuide. The issue was the following line in PublishGuide.groovy where project.ant was now org.gradle.api.AntBuilder and could not be cast to groovy.util.AntBuilder (publisher.ant), which was deprecated.
I now see that org.gradle.api.AntBuilder extends groovy.ant.AntBuilder, so I will create another PR to get rid of the internal Gradle package, which I didn't love. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of deprecated version from Groovy
required for grails/grails-async#140