Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grails gradle plugin usage since the plugins are not full grails apps #13968

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

jdaugherty
Copy link
Contributor

@jdaugherty jdaugherty commented Jan 10, 2025

Grails Plugins that do not provide views (need the view compiler) or do not run independently have no need for the grails gradle plugins. It's a better design to have a separate test project that imports the plugin to show the functionality.

Another way to put this: the gradle plugin seems to only impact the build of the plugin and not what's exported. If you only export the code via gradle & test externally it's not needed.

Going forward, this can lead to a huge amount of cleanup since we aren't including the grails gradle plugin, which is then including grails-core again, and many other side effects. It eliminates a key circular dependency that can cause unexpected behaviors and greatly simplifies our build files.

It also helps us decide what plugins to apply. For example, by not applying the grails gradle plugin, the dependency plugin doesn't get applied which gives us consistent resolution of dependencies.

Finally, it's overhead we don't need in our build process.

Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! And as long as the projects are in grails-core I don't think we will get much, if any, collateral damage.

@jdaugherty
Copy link
Contributor Author

I went ahead and fixed the ascii docs on this PR as well. Properties are now goign to generate in the documentation again =)

@jdaugherty
Copy link
Contributor Author

@matrei I made the uri() change per your other review.

@jamesfredley I fixed the ascii doc generation. I'm going to go ahead and merge so I can continue on the gsp updates. Let me know if you would prefer a different solution.

@jdaugherty jdaugherty merged commit 13862a4 into grails:7.0.x Jan 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants