Enhance PollingConditions usage in tests
#13985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the `assert` keyword in `PollingConditions` conditions, as recommended in the [API docs](https://spockframework.org/spock/javadoc/2.3/spock/util/concurrent/PollingConditions.html) and [documentation](https://spockframework.org/spock/docs/2.3/all_in_one.html#_polling_conditions). - Increase the delay for `PollingConditions` from the default 100ms to 200ms. This adjustment tries to address flakiness observed in CI environments, providing more stability for tests.
matrei
changed the title
PollingConditions usage in testsPollingConditions usage in tests
jdaugherty
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assertkeyword inPollingConditionsconditions, as recommended in the API docs and documentation.PollingConditionsfrom the default 100ms to 200ms. This adjustment tries to address flakiness observed in CI environments, providing more stability for tests.