Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove groovyVersion from gradle.properties #989

Merged
merged 3 commits into from
Mar 3, 2025
Merged

remove groovyVersion from gradle.properties #989

merged 3 commits into from
Mar 3, 2025

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Mar 3, 2025 •
edited
Loading

groovyVersion = System.getenv('CI_GROOVY_VERSION') is still used in the joint workflow, but reads from the groovy git repository.

matrei
matrei approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grailsVersion and grailsGradlePluginVersion are still at M. Should we go back to SNAPSHOT to see that nothing breaks?

@jamesfredley
Copy link
Contributor Author

Rerunning CI now. There were 4 milestone versions.

@matrei
Copy link
Contributor

matrei commented Mar 3, 2025

Hmm, we are not using the BOM as much as we can in this repo. Should we fix that before M3?

@jamesfredley
Copy link
Contributor Author

I'll make the grails-bom changes in the PR.

@jamesfredley jamesfredley merged commit 2a9fa9f into 9.0.x Mar 3, 2025
7 checks passed
@jamesfredley jamesfredley deleted the remove-groovyVersion branch March 3, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdaugherty jdaugherty jdaugherty left review comments

@matrei matrei matrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesfredley @matrei @jdaugherty