Add validation error on missing sidepost #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ef4 does this work for you? /cc @jackcasey @aribouius who were involved in the prior issue #214 (comment) |
[This issue](graphiti-api/graphiti-rails#65) raised the idea that we should be treating a missing sideposted record as a validation, not a 401. In the course of this work I found [this older PR](graphiti-api#214), which initially raised the same point iin [this comment](graphiti-api#214 (comment)). I very much agree that this should be a validation error, not a 401, but it breaks backwards compatibility. So, you can opt-in to this behavior with `Graphiti.config.raise_on_missing_sidepost = false`. We should consider this a best practice going forward and note it in the blog.
wadetandy
approved these changes
Feb 10, 2021
|
Looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue raised the idea that we should be treating a missing sideposted record as a validation, not a 401.
In the course of this work I found this older PR, which initially raised the same point in this comment.
I very much agree that this should be a validation error, not a 401, but it breaks backwards compatibility. So, you can opt-in to this behavior with
Graphiti.config.raise_on_missing_sidepost = false. We should consider this a best practice going forward and note it in the blog.