Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer-agent,-service: remove index-node configs #512

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Oct 17, 2022

Remove indexer agent's assignments for subgraph deployments to specific index nodes, instead encourages the use of graph-node toml configs for flexible deployment rules.

Currently the indexer agent and service take index-node id as provided at start-up, and round-robin the number of deployments on each node. We would like to make sure that graph node can balance deployments across available index-nodes with flexible deployment rules without conflicts from the agent.

Resolves #504

Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Let's do some testing in a multi indexing node environment to confirm that deployment assignments get properly balanced across the set of index nodes.

Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hopeyen hopeyen merged commit 94b5427 into main Oct 18, 2022
@hopeyen hopeyen deleted the hope/remove-index-node-assignments branch October 18, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indexer-agent: Leave index-node assignment decisions to index-nodes
2 participants